linux-kernel - Re: [PATCH] can: xilinx_can: Fix missing Rx can packets on CANFD2.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <885dca39-92be-50f1-8814-f14fa3271c7f@pengutronix.de>
Date:   Tue, 3 Dec 2019 12:16:23 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Srinivas Neeli <srinivas.neeli@...inx.com>, wg@...ndegger.com,
        davem@...emloft.net, michal.simek@...inx.com, appanad@...inx.com
Cc:     linux-can@...r.kernel.org, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        git@...inx.com, nagasure@...inx.com
Subject: Re: [PATCH] can: xilinx_can: Fix missing Rx can packets on CANFD2.0

On 12/3/19 12:12 PM, Srinivas Neeli wrote:
> CANFD2.0 core uses BRAM for storing acceptance filter ID(AFID) and MASK
> (AFMASK)registers. So by default AFID and AFMASK registers contain random
> data. Due to random data, not able to receive all CAN ids.
> 
> Initializing AFID and AFMASK registers with Zero before enabling
> acceptance filter to receive all packets irrespective of ID and Mask.
> 
> Signed-off-by: Srinivas Neeli <srinivas.neeli@...inx.com>
> Reviewed-by: Naga Sureshkumar Relli <naga.sureshkumar.relli@...inx.com>
> Signed-off-by: Michal Simek <michal.simek@...inx.com>

Please add a "Fixes:" tag.

Some nitpicks: Please add your S-o-B as the last one. Further I'd be
happier, if Naga Sureshkumar Relli adds the Reviewed-by in a seperate mail.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)