linux-kernel - Re: [PATCH v3 4/5] KVM: X86: Drop KVM_APIC_SHORT_MASK and KVM_APIC_DEST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191203162150.GC17275@xz-x1>
Date:   Tue, 3 Dec 2019 11:21:50 -0500
From:   Peter Xu <peterx@...hat.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>
Cc:     kvm@...r.kernel.org, Nitesh Narayan Lal <nitesh@...hat.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 4/5] KVM: X86: Drop KVM_APIC_SHORT_MASK and
 KVM_APIC_DEST_MASK

On Tue, Dec 03, 2019 at 02:19:16PM +0100, Vitaly Kuznetsov wrote:
> > @@ -4519,9 +4519,9 @@ static int avic_incomplete_ipi_interception(struct vcpu_svm *svm)
> >  		 */
> >  		kvm_for_each_vcpu(i, vcpu, kvm) {
> >  			bool m = kvm_apic_match_dest(vcpu, apic,
> > -						     icrl & KVM_APIC_SHORT_MASK,
> > +						     icrl & APIC_SHORT_MASK,
> >  						     GET_APIC_DEST_FIELD(icrh),
> > -						     icrl & KVM_APIC_DEST_MASK);
> > +						     icrl & APIC_DEST_MASK);
> >  
> >  			if (m && !avic_vcpu_is_running(vcpu))
> >  				kvm_vcpu_wake_up(vcpu);
> 
> Personal taste but I would've preserved KVM_ prefix. The patch itself
> looks correct, so

KVM apic uses apicdefs.h a lot, so I was trying to match them (APIC_*)
with it.

> 
> Reviewed-by: Vitaly Kuznetsov <vkuznets@...hat.com>

Thanks for the reviews,

-- 
Peter Xu