linux-kernel - Re: [PATCH] drm/crtc-helper: drm_connector_get_single_encoder prototype is missing

Open Source and information security mailing list archives

Date:   Tue, 3 Dec 2019 17:47:26 +0100
From:   Benjamin Gaignard <benjamin.gaignard@...aro.org>
To:     Benjamin GAIGNARD <benjamin.gaignard@...com>
Cc:     "Souza, Jose" <jose.souza@...el.com>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "maarten.lankhorst@...ux.intel.com" 
        <maarten.lankhorst@...ux.intel.com>,
        "mripard@...nel.org" <mripard@...nel.org>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "sean@...rly.run" <sean@...rly.run>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH] drm/crtc-helper: drm_connector_get_single_encoder
 prototype is missing

Le mer. 20 nov. 2019 à 00:28, Benjamin GAIGNARD
<benjamin.gaignard@...com> a écrit :
>
>
> On 11/19/19 7:53 PM, Souza, Jose wrote:
> > On Tue, 2019-11-19 at 13:58 +0100, Benjamin Gaignard wrote:
> >> Include drm_crtc_helper_internal.h to provide
> >> drm_connector_get_single_encoder
> >> prototype.
> >>
> >> Fixes: a92462d6bf493 ("drm/connector: Share with non-atomic drivers
> >> the function to get the single encoder")
> > drm_connector_get_single_encoder() is implemented before the use in
> > this file so it is not broken, no need of a fixes tag.
> >
> > Reviewed-by: José Roberto de Souza <jose.souza@...el.com>
>
> I will remove fixe tag before push it.
>
> Thanks,
>
> Benjamin

Applied on drm-misc-next with out Fixes tag.
Thanks for the review.

Benjamin

>
> >
> >> Cc: José Roberto de Souza <jose.souza@...el.com>
> >>
> >> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@...com>
> >> ---
> >>   drivers/gpu/drm/drm_crtc_helper.c | 2 ++
> >>   1 file changed, 2 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/drm_crtc_helper.c
> >> b/drivers/gpu/drm/drm_crtc_helper.c
> >> index 499b05aaccfc..93a4eec429e8 100644
> >> --- a/drivers/gpu/drm/drm_crtc_helper.c
> >> +++ b/drivers/gpu/drm/drm_crtc_helper.c
> >> @@ -48,6 +48,8 @@
> >>   #include <drm/drm_print.h>
> >>   #include <drm/drm_vblank.h>
> >>
> >> +#include "drm_crtc_helper_internal.h"
> >> +
> >>   /**
> >>    * DOC: overview
> >>    *
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives