[<prev] [next>] [day] [month] [year] [list]
Message-Id: <1575395876-12526-1-git-send-email-benjamin.h.shelton@intel.com>
Date: Tue, 3 Dec 2019 11:57:56 -0600
From: Ben Shelton <benjamin.h.shelton@...el.com>
To: linux-kernel@...r.kernel.org
Cc: Ben Shelton <benjamin.h.shelton@...el.com>,
Andy Whitcroft <apw@...onical.com>,
Joe Perches <joe@...ches.com>
Subject: [PATCH] checkpatch: Don't warn about returning EPOLL* defines
The EPOLL* defines are bit definitions, not errno values, so they should
be returned as-is, not as negative values.
Signed-off-by: Ben Shelton <benjamin.h.shelton@...el.com>
Cc: Andy Whitcroft <apw@...onical.com>
Cc: Joe Perches <joe@...ches.com>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 592911a..caad932 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -4867,7 +4867,7 @@ sub process {
}
# Return of what appears to be an errno should normally be negative
- if ($sline =~ /\breturn(?:\s*\(+\s*|\s+)(E[A-Z]+)(?:\s*\)+\s*|\s*)[;:,]/) {
+ if ($sline =~ /\breturn(?:\s*\(+\s*|\s+)(E(?!POLL)[A-Z]+)(?:\s*\)+\s*|\s*)[;:,]/) {
my $name = $1;
if ($name ne 'EOF' && $name ne 'ERROR') {
WARN("USE_NEGATIVE_ERRNO",
--
2.6.4
Powered by blists - more mailing lists