[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9044bad02aa6553cdb2523294500b50fccf3fd2a.camel@wdc.com>
Date: Wed, 4 Dec 2019 18:38:56 +0000
From: Alistair Francis <Alistair.Francis@....com>
To: "anup@...infault.org" <anup@...infault.org>,
"paul.walmsley@...ive.com" <paul.walmsley@...ive.com>
CC: "torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
"linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
Atish Patra <Atish.Patra@....com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"hch@....de" <hch@....de>
Subject: Re: [GIT PULL] Second set of RISC-V updates for v5.5-rc1
On Wed, 2019-12-04 at 18:22 +0530, Anup Patel wrote:
> On Wed, Dec 4, 2019 at 2:22 PM Paul Walmsley <
> paul.walmsley@...ive.com> wrote:
> > Linus,
> >
> > The following changes since commit
> > 5ba9aa56e6d3e8fddb954c2f818d1ce0525235bb:
> >
> > Merge branch 'next/nommu' into for-next (2019-11-22 18:59:09
> > -0800)
> >
> > are available in the Git repository at:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git
> > tags/riscv/for-v5.5-rc1-2
> >
> > for you to fetch changes up to
> > 1646220a6d4b27153ddb5ffb117aa1f4c39e3d1f:
> >
> > Merge branch 'next/defconfig-add-debug' into for-next (2019-11-22
> > 18:59:23 -0800)
> >
> > ----------------------------------------------------------------
> > Second set of RISC-V updates for v5.5-rc1
> >
> > A few minor RISC-V updates for v5.5-rc1 that arrived late.
> >
> > New features:
> >
> > - Dump some kernel virtual memory map details to the console if
> > CONFIG_DEBUG_VM is enabled
> >
> > Other improvements:
> >
> > - Enable more debugging options in the primary defconfigs
> >
> > Cleanups:
> >
> > - Clean up Kconfig indentation
> >
> > ----------------------------------------------------------------
> > Krzysztof Kozlowski (1):
> > riscv: Fix Kconfig indentation
> >
> > Paul Walmsley (4):
> > riscv: defconfigs: enable debugfs
> > riscv: defconfigs: enable more debugging options
>
> I had commented on your patch but my comments are still
> not addressed.
>
> Various debug options enabled by this patch have performance
> impact. Instead of enabling these debug options in primary
> defconfigs, I suggest to have separate debug defconfigs with
> these options enabled.
+1
OE uses the defconfig (as I'm sure other distros do) and slowing down
users seems like a bad idea.
Alistair
>
> Please address my comments and send this patch in
> separate PR.
>
> Regards,
> Anup
>
> > Merge branch 'next/misc2' into for-next
> > Merge branch 'next/defconfig-add-debug' into for-next
> >
> > Yash Shah (1):
> > RISC-V: Add address map dumper
> >
> > arch/riscv/Kconfig.socs | 16 ++++++++--------
> > arch/riscv/configs/defconfig | 24 ++++++++++++++++++++++++
> > arch/riscv/configs/rv32_defconfig | 24 ++++++++++++++++++++++++
> > arch/riscv/mm/init.c | 32
> > ++++++++++++++++++++++++++++++++
> > 4 files changed, 88 insertions(+), 8 deletions(-)
Powered by blists - more mailing lists