linux-kernel - Re: [PATCH 08/14] ARM: dts: swift: Cleanup gpio-keys-polled properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <450addb633e8572a019ccaec5fd48248@linux.vnet.ibm.com>
Date:   Wed, 04 Dec 2019 16:29:49 -0600
From:   Adriana Kobylak <anoo@...ux.ibm.com>
To:     Andrew Jeffery <andrew@...id.au>
Cc:     linux-aspeed@...ts.ozlabs.org, mark.rutland@....com,
        devicetree@...r.kernel.org, Adriana Kobylak <anoo@...ibm.com>,
        linux-kernel@...r.kernel.org, robh+dt@...nel.org,
        linux-arm-kernel@...ts.infradead.org,
        Linux-aspeed 
        <linux-aspeed-bounces+anoo=linux.ibm.com@...ts.ozlabs.org>
Subject: Re: [PATCH 08/14] ARM: dts: swift: Cleanup gpio-keys-polled
 properties

On 2019-12-03 06:04, Andrew Jeffery wrote:
> dtbs_check gave the following warning:
> 
>     Warning (avoid_unnecessary_addr_size): /gpio-keys-polled:
> unnecessary #address-cells/#size-cells without "ranges" or child "reg"
> property
> 
> Cc: Adriana Kobylak <anoo@...ibm.com>
> Signed-off-by: Andrew Jeffery <andrew@...id.au>
> Reviewed-by: Joel Stanley <joel@....id.au>

Reviewed-by: Adriana Kobylak <anoo@...ibm.com>
Tested-by: Adriana Kobylak <anoo@...ibm.com>

> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-swift.dts | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
> b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
> index 0831bc1f5a4c..555d79405884 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
> @@ -82,8 +82,6 @@
> 
>  	gpio-keys-polled {
>  		compatible = "gpio-keys-polled";
> -		#address-cells = <1>;
> -		#size-cells = <0>;
>  		poll-interval = <1000>;
> 
>  		scm0-presence {