linux-kernel - Re: [PATCH v2 -next] rtc: mt6397: drop free_irq of devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191204084036.GK909634@piout.net>
Date:   Wed, 4 Dec 2019 09:40:36 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Mao Wenan <maowenan@...wei.com>
Cc:     eddie.huang@...iatek.com, sean.wang@...iatek.com,
        a.zummo@...ertech.it, matthias.bgg@...il.com,
        dan.carpenter@...cle.com, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-rtc@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH v2 -next] rtc: mt6397: drop free_irq of devm_xx allocated
 irq

On 04/12/2019 15:28:26+0800, Mao Wenan wrote:
> rtc->irq is requested by devm_request_threaded_irq,
> and request_threaded_irq. IRQs requested with this
> function will be automatically freed on driver detach.
> This patch remove unused error label as well.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Mao Wenan <maowenan@...wei.com>
> ---
>  v2: remove error label as Dan Carpenter suggest.
>  drivers/rtc/rtc-mt6397.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
> index 5249fc99fd5f..14f3c4915260 100644
> --- a/drivers/rtc/rtc-mt6397.c
> +++ b/drivers/rtc/rtc-mt6397.c
> @@ -287,13 +287,6 @@ static int mtk_rtc_probe(struct platform_device *pdev)
>  	rtc->rtc_dev->ops = &mtk_rtc_ops;
>  
>  	ret = rtc_register_device(rtc->rtc_dev);
> -	if (ret)
> -		goto out_free_irq;
> -
> -	return 0;
> -
> -out_free_irq:
> -	free_irq(rtc->irq, rtc);
>  	return ret;

Maybe return rtc_register_device(rtc->rtc_dev); 

>  }
>  
> -- 
> 2.20.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com