linux-kernel - [PATCH V3] media: ov5640: Fix check for PLL1 exceeding max allowed rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed,  4 Dec 2019 07:35:42 -0600
From:   Adam Ford <aford173@...il.com>
To:     linux-media@...r.kernel.org
Cc:     adam.ford@...icpd.com, maxime.ripard@...tlin.com,
        Adam Ford <aford173@...il.com>,
        Jacopo Mondi <jacopo@...ndi.org>,
        Steve Longerbeam <slongerbeam@...il.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: [PATCH V3] media: ov5640: Fix check for PLL1 exceeding max allowed rate

The PLL calculation routine checks the wrong variable name 'rate'
when it should be called '_rate' when checking to see whether or
not the PLL1 output frequency exceeds 1GHz.

This patch changes it to the correct variable '_rate'

Fixes: aa2882481cad ("media: ov5640: Adjust the clock based on the expected rate")

Acked-by: Jacopo Mondi <jacopo@...ndi.org>
Signed-off-by: Adam Ford <aford173@...il.com>
---
V3:  Add Fixes Tag.
V2:  No code change.  Only change commit description to be less confusing.

diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index 500d9bbff10b..a3c0be56ae02 100644
--- a/drivers/media/i2c/ov5640.c
+++ b/drivers/media/i2c/ov5640.c
@@ -874,7 +874,7 @@ static unsigned long ov5640_calc_sys_clk(struct ov5640_dev *sensor,
 			 * We have reached the maximum allowed PLL1 output,
 			 * increase sysdiv.
 			 */
-			if (!rate)
+			if (!_rate)
 				break;
 
 			/*
-- 
2.20.1