linux-kernel - Re: [PATCH] bus: fsl-mc: properly empty-initialize structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 4 Dec 2019 15:01:18 +0000
From:   Laurentiu Tudor <laurentiu.tudor@....com>
To:     Ioana Ciornei <ioana.ciornei@....com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bus: fsl-mc: properly empty-initialize structure



On 04.12.2019 16:29, Ioana Ciornei wrote:
> Use the proper form of the empty initializer when working with
> structures that contain an array. Otherwise, older gcc versions (eg gcc
> 4.9) will complain about this.
> 
> Fixes: 1ac210d128ef ("bus: fsl-mc: add the fsl_mc_get_endpoint function")
> Reported-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>

Thanks,

Acked-by: Laurentiu Tudor <laurentiu.tudor@....com>

---
Best Regards, Laurentiu

> ---
>   drivers/bus/fsl-mc/fsl-mc-bus.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c
> index a07cc19becdb..c78d10ea641f 100644
> --- a/drivers/bus/fsl-mc/fsl-mc-bus.c
> +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c
> @@ -715,9 +715,9 @@ EXPORT_SYMBOL_GPL(fsl_mc_device_remove);
>   struct fsl_mc_device *fsl_mc_get_endpoint(struct fsl_mc_device *mc_dev)
>   {
>   	struct fsl_mc_device *mc_bus_dev, *endpoint;
> -	struct fsl_mc_obj_desc endpoint_desc = { 0 };
> -	struct dprc_endpoint endpoint1 = { 0 };
> -	struct dprc_endpoint endpoint2 = { 0 };
> +	struct fsl_mc_obj_desc endpoint_desc = {{ 0 }};
> +	struct dprc_endpoint endpoint1 = {{ 0 }};
> +	struct dprc_endpoint endpoint2 = {{ 0 }};
>   	int state, err;
>   
>   	mc_bus_dev = to_fsl_mc_device(mc_dev->dev.parent);
>