linux-kernel - Re: [PATCH 3/4] dt-bindings: at24: remove the optional property write-protect-gpios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191204152236.GA22464@bogus>
Date:   Wed, 4 Dec 2019 09:22:36 -0600
From:   Rob Herring <robh@...nel.org>
To:     Khouloud Touil <ktouil@...libre.com>
Cc:     bgolaszewski@...libre.com, mark.rutland@....com,
        srinivas.kandagatla@...aro.org, baylibre-upstreaming@...ups.io,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-i2c@...r.kernel.org, linus.walleij@...aro.org
Subject: Re: [PATCH 3/4] dt-bindings: at24: remove the optional property
 write-protect-gpios

On Wed, Nov 20, 2019 at 03:20:37PM +0100, Khouloud Touil wrote:
> NVMEM framework is an interface for the at24 EEPROMs as well as for
> other drivers, instead of passing the wp-gpios over the different
> drivers each time, it would be better to pass it over the NVMEM
> subsystem once and for all.
> 
> Removing the optional property form the device tree binding document.
> 
> Signed-off-by: Khouloud Touil <ktouil@...libre.com>
> ---
>  Documentation/devicetree/bindings/eeprom/at24.yaml | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
> index e8778560d966..9894237ac432 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.yaml
> +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
> @@ -145,11 +145,6 @@ properties:
>        over reads to the next slave address. Please consult the manual of
>        your device.
>  
> -  wp-gpios:
> -    description:
> -      GPIO to which the write-protect pin of the chip is connected.
> -    maxItems: 1
> -

At least 'wp-gpios: true' is still needed or you need to reference the 
common definition in nvmem.yaml. The reason being is every possible 
property (and child node) needs to be listed so we can have errors on 
any that aren't.

Rob