linux-kernel - Re: [PATCH v5 linux-kselftest-test 3/6] kunit: allow kunit tests to be loaded as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.20.1912041530210.5511@dhcp-10-175-179-22.vpn.oracle.com>
Date:   Wed, 4 Dec 2019 15:30:46 +0000 (GMT)
From:   Alan Maguire <alan.maguire@...cle.com>
To:     Iurii Zaikin <yzaikin@...gle.com>
cc:     Alan Maguire <alan.maguire@...cle.com>,
        Brendan Higgins <brendanhiggins@...gle.com>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        KUnit Development <kunit-dev@...glegroups.com>,
        Kees Cook <keescook@...omium.org>, akpm@...ux-foundation.org,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        catalin.marinas@....com, joe.lawrence@...hat.com,
        penguin-kernel@...ove.sakura.ne.jp, urezki@...il.com,
        andriy.shevchenko@...ux.intel.com, corbet@....net,
        David Gow <davidgow@...gle.com>, adilger.kernel@...ger.ca,
        "Theodore Ts'o" <tytso@....edu>,
        Luis Chamberlain <mcgrof@...nel.org>,
        "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
        Knut Omang <knut.omang@...cle.com>
Subject: Re: [PATCH v5 linux-kselftest-test 3/6] kunit: allow kunit tests to
 be loaded as a module

On Tue, 3 Dec 2019, Iurii Zaikin wrote:

> > +ifeq ($(CONFIG_EXT4_KUNIT_TESTS),y)
> >  ext4-$(CONFIG_EXT4_KUNIT_TESTS)                += inode-test.o
> > +else
> > +obj-$(CONFIG_EXT4_KUNIT_TESTS)         += ext4-inode-test.o
> > +ext4-inode-test-objs                   += inode-test.o
> > +endif
> Why not rename it unconditionally?
> 

Good point - I've fixed this in v6. Thanks for the review!

Alan