linux-kernel - Re: [PATCH] erofs: zero out when listxattr is called with no xattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <947ae429-d206-0859-ee5b-9bd37f7fd72b@huawei.com>
Date:   Wed, 4 Dec 2019 11:14:37 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Gao Xiang <hsiangkao@....com>, <linux-erofs@...ts.ozlabs.org>
CC:     LKML <linux-kernel@...r.kernel.org>,
        David Michael <fedora.dm0@...il.com>,
        Miao Xie <miaoxie@...wei.com>, Fang Wei <fangwei1@...wei.com>,
        Wang Li <wangli74@...wei.com>,
        Gao Xiang <gaoxiang25@...wei.com>, <stable@...r.kernel.org>
Subject: Re: [PATCH] erofs: zero out when listxattr is called with no xattr

On 2019/12/1 16:40, Gao Xiang wrote:
> From: Gao Xiang <gaoxiang25@...wei.com>
> 
> As David reported [1], ENODATA returns when attempting
> to modify files by using EROFS as a overlayfs lower layer.
> 
> The root cause is that listxattr could return unexpected
> -ENODATA by mistake for inodes without xattr. That breaks
> listxattr return value convention and it can cause copy
> up failure when used with overlayfs.
> 
> Resolve by zeroing out if no xattr is found for listxattr.
> 
> [1] https://lore.kernel.org/r/CAEvUa7nxnby+rxK-KRMA46=exeOMApkDMAV08AjMkkPnTPV4CQ@mail.gmail.com
> Fixes: cadf1ccf1b00 ("staging: erofs: add error handling for xattr submodule")
> Cc: <stable@...r.kernel.org> # 4.19+
> Signed-off-by: Gao Xiang <gaoxiang25@...wei.com>

Reviewed-by: Chao Yu <yuchao0@...wei.com>

Thanks,