linux-kernel - Re: [PATCH 1/5] gpio: export acpi_gpiochip_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vc4qPeVmzgn8fn+EweoSoKveK5tDS=RwmfASojDcxuWBA@mail.gmail.com>
Date:   Wed, 4 Dec 2019 19:44:36 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Clément Leger <cleger@...ray.eu>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        "open list, GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH 1/5] gpio: export acpi_gpiochip_request_interrupts in gpio/driver.h

On Wed, Dec 4, 2019 at 3:39 PM Clément Leger <cleger@...ray.eu> wrote:

> Ok, should I fix the original driver first and then submit the serie to add pinctrl ?

I guess so. Because we definitely don't want a churn with exporting
symbols like this.

> ----- On 4 Dec, 2019, at 13:35, Andy Shevchenko andy.shevchenko@...il.com wrote:
> > On Wed, Dec 4, 2019 at 12:13 PM Clement Leger <cleger@...ray.eu> wrote:
> >>
> >> dwapb-gpio driver which uses this function will be moved to pinctrl for
> >> pinctrl support. Export this function in gpio/driver.h to allow using
> >> it.

> > I don't think this is proper way to do it.
> > The driver has to register IRQ chip and GPIO core will take care of
> > ACPI related stuff.

-- 
With Best Regards,
Andy Shevchenko