lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 4 Dec 2019 04:20:41 +0000 From: Peng Fan <peng.fan@....com> To: "rjui@...adcom.com" <rjui@...adcom.com>, "linus.walleij@...aro.org" <linus.walleij@...aro.org>, "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>, "f.fainelli@...il.com" <f.fainelli@...il.com>, "sbranden@...adcom.com" <sbranden@...adcom.com>, "thierry.reding@...il.com" <thierry.reding@...il.com>, "robh@...nel.org" <robh@...nel.org> CC: "bcm-kernel-feedback-list@...adcom.com" <bcm-kernel-feedback-list@...adcom.com>, "u.kleine-koenig@...gutronix.de" <u.kleine-koenig@...gutronix.de>, dl-linux-imx <linux-imx@....com>, "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>, "linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Alice Guo <alice.guo@....com>, Peng Fan <peng.fan@....com> Subject: [PATCH v2 1/2] gpio: mvebu: use platform_irq_count From: Peng Fan <peng.fan@....com> platform_irq_count() is the more generic way (independent of device trees) to determine the count of available interrupts. So use this instead. As platform_irq_count() might return an error code (which of_irq_count doesn't) some additional handling is necessary. Signed-off-by: Peng Fan <peng.fan@....com> --- V2: Update commit log, add err handling Not tested, just code inspection drivers/gpio/gpio-mvebu.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c index 993bbeb3c006..f0fd82b3417c 100644 --- a/drivers/gpio/gpio-mvebu.c +++ b/drivers/gpio/gpio-mvebu.c @@ -46,7 +46,6 @@ #include <linux/irqdomain.h> #include <linux/mfd/syscon.h> #include <linux/of_device.h> -#include <linux/of_irq.h> #include <linux/pinctrl/consumer.h> #include <linux/platform_device.h> #include <linux/pwm.h> @@ -1102,7 +1101,11 @@ static int mvebu_gpio_probe(struct platform_device *pdev) soc_variant = MVEBU_GPIO_SOC_VARIANT_ORION; /* Some gpio controllers do not provide irq support */ - have_irqs = of_irq_count(np) != 0; + err = platform_irq_count(pdev); + if (err < 0) + return err; + + have_irqs = err != 0; mvchip = devm_kzalloc(&pdev->dev, sizeof(struct mvebu_gpio_chip), GFP_KERNEL); -- 2.16.4
Powered by blists - more mailing lists