linux-kernel - Re: [PATCH 2/2] fix the SPDX syntax and bash interprester pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56303cd3-fcf8-49cd-f66a-4db7e382774c@infradead.org>
Date:   Wed, 4 Dec 2019 19:36:32 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Bhaskar Chowdhury <unixbhaskar@...il.com>,
        yamada.masahiro@...ionext.com, michal.lkml@...kovi.net
Cc:     linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] fix the SPDX syntax and bash interprester pointer

On 12/3/19 1:53 AM, Bhaskar Chowdhury wrote:
> SPDX syntax was complining by checkpatch fixed it,added space before it.
> And add bash interpreter to find by the env .
> 
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@...il.com>
> ---
>  scripts/kernel_modules_info.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/kernel_modules_info.sh b/scripts/kernel_modules_info.sh
> index f005c47a3aa6..3a9b00988ed3 100755
> --- a/scripts/kernel_modules_info.sh
> +++ b/scripts/kernel_modules_info.sh
> @@ -1,5 +1,5 @@
> -#!/bin/bash - 
> -#SPDX-License-Identifier: GPL-2.0
> +#!/usr/bin/env bash 
> +# SPDX-License-Identifier: GPL-2.0
>  #===============================================================================
>  #
>  #          FILE: kernel_modules_info.sh
> 

a.  There is no good reason for patch 2/2.  Just merge the 2 patches.

b.  The big header comment in patch 1/2 is not needed and is unwanted.
Just put some or all of that in the patch description/comment message.


-- 
~Randy