linux-kernel - Re: [PATCH 1/1] pinctrl: Modify Kconfig to fix linker error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b92f1c7c-efdb-340d-dbfa-2a083732d8fb@infradead.org>
Date:   Wed, 4 Dec 2019 19:42:08 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Rahul Tanwar <rahul.tanwar@...ux.intel.com>,
        linus.walleij@...aro.org
Cc:     sfr@...b.auug.org.au, linux-next@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH 1/1] pinctrl: Modify Kconfig to fix linker error

On 12/4/19 7:01 PM, Rahul Tanwar wrote:
> Fix below linker error
> 
>     ld: drivers/pinctrl/pinctrl-equilibrium.o: in function
>     `pinconf_generic_dt_node_to_map_all':
>     pinctrl-equilibrium.c:(.text+0xb): undefined reference
>     to `pinconf_generic_dt_node_to_map'
> 
> Caused by below commit
> 
>     1948d5c51dba ("pinctrl: Add pinmux & GPIO controller driver for a new SoC")
> 
> by adding 'depends on OF' in Kconfig driver entry.
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>>
> Signed-off-by: Rahul Tanwar <rahul.tanwar@...ux.intel.com>

Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested


Thanks.

> ---
>  drivers/pinctrl/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 3bfbf2ff6e2b..ba0cad4bd072 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -422,6 +422,7 @@ config PINCTRL_TB10X
>  
>  config PINCTRL_EQUILIBRIUM
>  	tristate "Generic pinctrl and GPIO driver for Intel Lightning Mountain SoC"
> +	depends on OF
>  	select PINMUX
>  	select PINCONF
>  	select GPIOLIB
> 


-- 
~Randy