linux-kernel - Re: [v2 PATCH] mm: move_pages: return valid node id in status if the page is already on the target node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <565bf53f-1a08-d472-30ac-cf9953e1490a@nvidia.com>
Date:   Wed, 4 Dec 2019 21:50:37 -0800
From:   John Hubbard <jhubbard@...dia.com>
To:     Yang Shi <yang.shi@...ux.alibaba.com>, <fabecassis@...dia.com>,
        <mhocko@...e.com>, <cl@...ux.com>, <vbabka@...e.cz>,
        <mgorman@...hsingularity.net>, <akpm@...ux-foundation.org>
CC:     <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
        <stable@...r.kernel.org>
Subject: Re: [v2 PATCH] mm: move_pages: return valid node id in status if the
 page is already on the target node

On 12/4/19 9:44 PM, John Hubbard wrote:
...           */
> 
> Let's change the comment above add_page_for_migration(), to read:
> 
>          /*
>           * Most errors in the page lookup or isolation are not fatal
>           * and we simply report them via the status array. However,
>           * positive error values are fatal.
>           */
> 
> 
>>           err = add_page_for_migration(mm, addr, current_node,
>> -                &pagelist, flags & MPOL_MF_MOVE_ALL);
>> +                &pagelist, flags & MPOL_MF_MOVE_ALL, status,
>> +                i);
>> +
>>           if (!err)
>>               continue;
>> +        /* store_status() failed in add_page_for_migration() */
> 
> ...and let's replace the above line, with the following:
> 

Correction, I experienced a fatal editor copy-paste mistake here. :) I meant to
suggest this:

		/*
		 * add_page_for_migration() experienced a fatal failure (see the
		 * comments in that routine for details).
		 */

> 
> 
>> +        if (err > 0) {
>> +            err = -EFAULT;
>> +            goto out_flush;
>> +        }
>> +
>>           err = store_status(status, i, err, 1);
>>           if (err)
>>               goto out_flush;
>>

thanks,
-- 
John Hubbard
NVIDIA