linux-kernel - RE: [PATCH] Input: goodix - support gt9147 touchpanel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bd51e553feb74f6fb3a7115463d52e66@SFHDAG6NODE1.st.com>
Date:   Thu, 5 Dec 2019 08:30:26 +0000
From:   Yannick FERTRE <yannick.fertre@...com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Rob Herring <robh+dt@...nel.org>
CC:     Philippe CORNU <philippe.cornu@...com>,
        Benjamin GAIGNARD <benjamin.gaignard@...com>,
        Bastien Nocera <hadess@...ess.net>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] Input: goodix - support gt9147 touchpanel

Hello,
Dmitry,
I forgot to modify the binding to declare the new compatible "gt9147".
Rob,
can I modify the binding without converting it first to yaml?

Best regards

Yannick Fertré

-----Original Message-----
From: Dmitry Torokhov <dmitry.torokhov@...il.com> 
Sent: dimanche 1 décembre 2019 04:08
To: Yannick FERTRE <yannick.fertre@...com>; Rob Herring <robh+dt@...nel.org>
Cc: Philippe CORNU <philippe.cornu@...com>; Benjamin GAIGNARD <benjamin.gaignard@...com>; Bastien Nocera <hadess@...ess.net>; linux-input@...r.kernel.org; linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: goodix - support gt9147 touchpanel

On Wed, Nov 27, 2019 at 11:28:46AM +0100, Yannick Fertre wrote:
> From: Yannick Fertré <yannick.fertre@...com>
> 
> Add support for it by adding compatible and supported chip data 
> (default settings used).
> The chip data on GT9147 is similar to GT912, like
> - config data register has 0x8047 address
> - config data register max len is 240
> - config data checksum has 8-bit

If it is compatible with gt912 then the driver does not need another compatible in the code I think. Rob will tell more.

> 
> Signed-off-by: Yannick Fertre <yannick.fertre@...com>
> ---
>  drivers/input/touchscreen/goodix.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/touchscreen/goodix.c 
> b/drivers/input/touchscreen/goodix.c
> index fb43aa7..b470773 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -1045,6 +1045,7 @@ static const struct of_device_id goodix_of_match[] = {
>  	{ .compatible = "goodix,gt9271" },
>  	{ .compatible = "goodix,gt928" },
>  	{ .compatible = "goodix,gt967" },
> +	{ .compatible = "goodix,gt9147",},
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(of, goodix_of_match);
> --
> 2.7.4
> 

-- 
Dmitry