linux-kernel - Re: [PATCH] ppp: fix out-of-bounds access in bpf_prog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2Fka2tuCnYAsSM8DHVzV9Zpvj_J7rkGg6zgWLEsU3KAw@mail.gmail.com>
Date:   Thu, 5 Dec 2019 10:07:37 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     Al Viro <viro@...iv.linux.org.uk>,
        Paul Mackerras <paulus@...ba.org>, bpf@...r.kernel.org,
        Linux FS-devel Mailing List <linux-fsdevel@...r.kernel.org>,
        linux-ppp@...r.kernel.org, Networking <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        syzbot <syzbot+eb853b51b10f1befa0b7@...kaller.appspotmail.com>,
        syzkaller-bugs <syzkaller-bugs@...glegroups.com>
Subject: Re: [PATCH] ppp: fix out-of-bounds access in bpf_prog_create()

On Thu, Dec 5, 2019 at 6:55 AM Eric Biggers <ebiggers@...nel.org> wrote:
>
> From: Eric Biggers <ebiggers@...gle.com>
>
> sock_fprog_kern::len is in units of struct sock_filter, not bytes.
>
> Fixes: 3e859adf3643 ("compat_ioctl: unify copy-in of ppp filters")
> Reported-by: syzbot+eb853b51b10f1befa0b7@...kaller.appspotmail.com
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Reviewed-by: Arnd Bergmann <arnd@...db.de>

Thanks for fixing the bug I introduced!