linux-kernel - Re: [PATCH v2 1/2] gpio: mvebu: use platform_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMpxmJU-WK1aXK3M_q12E_u8+wwEimuonmjFa7Hm3Z6Dp7DP_g@mail.gmail.com>
Date:   Thu, 5 Dec 2019 10:22:53 +0100
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     Peng Fan <peng.fan@....com>,
        "rjui@...adcom.com" <rjui@...adcom.com>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "sbranden@...adcom.com" <sbranden@...adcom.com>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        "robh@...nel.org" <robh@...nel.org>,
        "bcm-kernel-feedback-list@...adcom.com" 
        <bcm-kernel-feedback-list@...adcom.com>,
        dl-linux-imx <linux-imx@....com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Alice Guo <alice.guo@....com>,
        Sascha Hauer <kernel@...gutronix.de>
Subject: Re: [PATCH v2 1/2] gpio: mvebu: use platform_irq_count

śr., 4 gru 2019 o 19:47 Uwe Kleine-König
<u.kleine-koenig@...gutronix.de> napisał(a):
>
> On Wed, Dec 04, 2019 at 05:33:04PM +0100, Bartosz Golaszewski wrote:
> > śr., 4 gru 2019 o 08:24 Uwe Kleine-König
> > <u.kleine-koenig@...gutronix.de> napisał(a):
> > >
> > > On Wed, Dec 04, 2019 at 04:20:41AM +0000, Peng Fan wrote:
> > > > From: Peng Fan <peng.fan@....com>
> > > >
> > > > platform_irq_count() is the more generic way (independent of
> > > > device trees) to determine the count of available interrupts. So
> > > > use this instead.
> > > >
> > > > As platform_irq_count() might return an error code (which
> > > > of_irq_count doesn't) some additional handling is necessary.
> > > >
> > > > Signed-off-by: Peng Fan <peng.fan@....com>
> > > Reviewed-and-Commit-Log-Provided-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> >
> > This is not a valid tag, but I take it as Suggested-by and Reviewed-by. :)
>
> If you care about the validity of such tags, I suggest you take a look
> at the output of
>
>         $ git rev-list v4.0..v5.4 | while read rev; do git cat-file commit $rev; done | sed -n 's/ *\(.*-by\):.*/\1/p' | sort | uniq -c | sort -n
>
> (which finds all tags used between 4.0 and 5.4 with its usage count).
>
> A few of the tags (admittedly with low usage count :-) included there are:
>
>   Badly-reviewed-by
>   Bonus-points-awarded-by
>   Compile-tested and Reviewed-by
>   Enthusiastically-Acked-by
>   Mea-culpa-by
>   \o/-by
>   Brown-paper-bag-by
>
> Best regards
> Uwe

I am well aware of this and there has been a discussion on LKML some
time ago (I can no longer find it though) about introducing stricter
rules for tags. I don't remember the outcome either though.

Bart