linux-kernel - Re: [PATCH 2/2] act_ct: support asymmetric conntrack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191204.163348.259023660348933654.davem@davemloft.net>
Date:   Wed, 04 Dec 2019 16:33:48 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     aconole@...hat.com
Cc:     netdev@...r.kernel.org, pshelar@....org, jhs@...atatu.com,
        xiyou.wangcong@...il.com, jiri@...nulli.us, dev@...nvswitch.org,
        linux-kernel@...r.kernel.org, mleitner@...hat.com,
        paulb@...lanox.com, roid@...lanox.com, nicolas.dichtel@...nd.com
Subject: Re: [PATCH 2/2] act_ct: support asymmetric conntrack

From: Aaron Conole <aconole@...hat.com>
Date: Tue,  3 Dec 2019 16:34:14 -0500

> The act_ct TC module shares a common conntrack and NAT infrastructure
> exposed via netfilter.  It's possible that a packet needs both SNAT and
> DNAT manipulation, due to e.g. tuple collision.  Netfilter can support
> this because it runs through the NAT table twice - once on ingress and
> again after egress.  The act_ct action doesn't have such capability.
> 
> Like netfilter hook infrastructure, we should run through NAT twice to
> keep the symmetry.
> 
> Fixes: b57dc7c13ea9 ("net/sched: Introduce action ct")
> 
> Signed-off-by: Aaron Conole <aconole@...hat.com>
> Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
> ---
> NOTE: this is a repost to see if the email client issues go away.

Applied and queued up for -stable.

Next time, please:

1) Provide an introductory posting ala "[PATCH net 0/N] ..." describing
   what the patch series does on a high level, how it is doing it, and
   why it is doing it that way.

   This allows people to understand what they are about to read, and it
   gives me a single mail to respon to when I apply your entire series.

2) Always clearly indicate the target GIT tree in your Subject line,
   in these cases it should have been "[PATCH net N/M]"

Thank you.