linux-kernel - Re: [PATCH] Bluetooth: btusb: Disable runtime suspend on Realtek devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <F8377E2D-EB26-4AF4-83B2-A7903C4A4D2D@holtmann.org>
Date:   Thu, 5 Dec 2019 10:32:19 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        Alex Lu <alex_lu@...lsil.com.cn>, pkshih@...ltek.com,
        linux-bluetooth@...r.kernel.or, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: btusb: Disable runtime suspend on Realtek
 devices

Hi Kai-Heng,

> After commit 9e45524a0111 ("Bluetooth: btusb: Fix suspend issue for
> Realtek devices") both WiFi and Bluetooth stop working after reboot:
> [   34.322617] usb 1-8: reset full-speed USB device number 3 using xhci_hcd
> [   34.450401] usb 1-8: device descriptor read/64, error -71
> [   34.694375] usb 1-8: device descriptor read/64, error -71
> ...
> [   44.599111] rtw_pci 0000:02:00.0: failed to poll offset=0x5 mask=0x3 value=0x0
> [   44.599113] rtw_pci 0000:02:00.0: mac power on failed
> [   44.599114] rtw_pci 0000:02:00.0: failed to power on mac
> [   44.599114] rtw_pci 0000:02:00.0: leave idle state failed
> [   44.599492] rtw_pci 0000:02:00.0: failed to leave ips state
> [   44.599493] rtw_pci 0000:02:00.0: failed to leave idle state
> 
> That commit removed USB_QUIRK_RESET_RESUME, which not only resets the USB
> device after resume, it also prevents the device from being runtime
> suspended by USB core. My experiment shows if the Realtek btusb device
> ever runtime suspends once, the entire wireless module becomes useless
> after reboot.
> 
> So let's explicitly disable runtime suspend on Realtek btusb device for
> now.
> 
> Fixes: 9e45524a0111 ("Bluetooth: btusb: Fix suspend issue for Realtek devices")
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
> ---
> drivers/bluetooth/btusb.c | 4 ++++
> 1 file changed, 4 insertions(+)

patch has been applied to bluetooth-next tree.

Regards

Marcel