linux-kernel - Re: [PATCH] [EFI,PCI] Allow disabling PCI busmastering on bridges during boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 5 Dec 2019 21:04:59 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Matthew Garrett <matthewgarrett@...gle.com>
Cc:     kbuild-all@...ts.01.org, linux-efi@...r.kernel.org,
        ard.biesheuvel@...aro.org, x86@...nel.org,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        Matthew Garrett <matthewgarrett@...gle.com>,
        Matthew Garrett <mjg59@...gle.com>
Subject: Re: [PATCH] [EFI,PCI] Allow disabling PCI busmastering on bridges
 during boot

Hi Matthew,

I love your patch! Yet something to improve:

[auto build test ERROR on v5.4-rc8]
[also build test ERROR on linux/master]
[cannot apply to efi/next linus/master next-20191203]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Matthew-Garrett/Allow-disabling-PCI-busmastering-on-bridges-during-boot/20191203-084747
base:    af42d3466bdc8f39806b26f593604fdc54140bcb
config: arm-multi_v7_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from drivers/firmware/efi/libstub/pci.c:12:0:
   drivers/firmware/efi/libstub/pci.c: In function 'efi_pci_disable_bridge_busmaster':
>> arch/arm/include/asm/efi.h:53:33: error: 'sys_table_arg' undeclared (first use in this function); did you mean 'sys_table'?
    #define efi_call_early(f, ...)  sys_table_arg->boottime->f(__VA_ARGS__)
                                    ^
   drivers/firmware/efi/libstub/pci.c:29:11: note: in expansion of macro 'efi_call_early'
     status = efi_call_early(locate_handle,
              ^~~~~~~~~~~~~~
   arch/arm/include/asm/efi.h:53:33: note: each undeclared identifier is reported only once for each function it appears in
    #define efi_call_early(f, ...)  sys_table_arg->boottime->f(__VA_ARGS__)
                                    ^
   drivers/firmware/efi/libstub/pci.c:29:11: note: in expansion of macro 'efi_call_early'
     status = efi_call_early(locate_handle,
              ^~~~~~~~~~~~~~
>> arch/arm/include/asm/efi.h:62:3: error: called object is not a function or function pointer
     ((protocol##_t *)instance)->f(instance, ##__VA_ARGS__)
     ~^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/firmware/efi/libstub/pci.c:62:12: note: in expansion of macro 'efi_call_proto'
      status = efi_call_proto(efi_pci_io_protocol, pci.read, pci,
               ^~~~~~~~~~~~~~
>> arch/arm/include/asm/efi.h:62:3: error: called object is not a function or function pointer
     ((protocol##_t *)instance)->f(instance, ##__VA_ARGS__)
     ~^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/firmware/efi/libstub/pci.c:70:12: note: in expansion of macro 'efi_call_proto'
      status = efi_call_proto(efi_pci_io_protocol, pci.read, pci,
               ^~~~~~~~~~~~~~
>> arch/arm/include/asm/efi.h:62:3: error: called object is not a function or function pointer
     ((protocol##_t *)instance)->f(instance, ##__VA_ARGS__)
     ~^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/firmware/efi/libstub/pci.c:78:12: note: in expansion of macro 'efi_call_proto'
      status = efi_call_proto(efi_pci_io_protocol, pci.write, pci,
               ^~~~~~~~~~~~~~
--
   In file included from drivers/firmware//efi/libstub/pci.c:12:0:
   drivers/firmware//efi/libstub/pci.c: In function 'efi_pci_disable_bridge_busmaster':
>> arch/arm/include/asm/efi.h:53:33: error: 'sys_table_arg' undeclared (first use in this function); did you mean 'sys_table'?
    #define efi_call_early(f, ...)  sys_table_arg->boottime->f(__VA_ARGS__)
                                    ^
   drivers/firmware//efi/libstub/pci.c:29:11: note: in expansion of macro 'efi_call_early'
     status = efi_call_early(locate_handle,
              ^~~~~~~~~~~~~~
   arch/arm/include/asm/efi.h:53:33: note: each undeclared identifier is reported only once for each function it appears in
    #define efi_call_early(f, ...)  sys_table_arg->boottime->f(__VA_ARGS__)
                                    ^
   drivers/firmware//efi/libstub/pci.c:29:11: note: in expansion of macro 'efi_call_early'
     status = efi_call_early(locate_handle,
              ^~~~~~~~~~~~~~
>> arch/arm/include/asm/efi.h:62:3: error: called object is not a function or function pointer
     ((protocol##_t *)instance)->f(instance, ##__VA_ARGS__)
     ~^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/firmware//efi/libstub/pci.c:62:12: note: in expansion of macro 'efi_call_proto'
      status = efi_call_proto(efi_pci_io_protocol, pci.read, pci,
               ^~~~~~~~~~~~~~
>> arch/arm/include/asm/efi.h:62:3: error: called object is not a function or function pointer
     ((protocol##_t *)instance)->f(instance, ##__VA_ARGS__)
     ~^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/firmware//efi/libstub/pci.c:70:12: note: in expansion of macro 'efi_call_proto'
      status = efi_call_proto(efi_pci_io_protocol, pci.read, pci,
               ^~~~~~~~~~~~~~
>> arch/arm/include/asm/efi.h:62:3: error: called object is not a function or function pointer
     ((protocol##_t *)instance)->f(instance, ##__VA_ARGS__)
     ~^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/firmware//efi/libstub/pci.c:78:12: note: in expansion of macro 'efi_call_proto'
      status = efi_call_proto(efi_pci_io_protocol, pci.write, pci,
               ^~~~~~~~~~~~~~

vim +53 arch/arm/include/asm/efi.h

81a0bc39ea1960 Roy Franz      2015-09-23  52  
81a0bc39ea1960 Roy Franz      2015-09-23 @53  #define efi_call_early(f, ...)		sys_table_arg->boottime->f(__VA_ARGS__)
fc37206427ce38 Ard Biesheuvel 2016-04-25  54  #define __efi_call_early(f, ...)	f(__VA_ARGS__)
6d0ca4a47bf8cb David Howells  2017-02-06  55  #define efi_call_runtime(f, ...)	sys_table_arg->runtime->f(__VA_ARGS__)
fc37206427ce38 Ard Biesheuvel 2016-04-25  56  #define efi_is_64bit()			(false)
81a0bc39ea1960 Roy Franz      2015-09-23  57  
c4db9c1e8c70bc Lukas Wunner   2018-07-20  58  #define efi_table_attr(table, attr, instance)				\
c4db9c1e8c70bc Lukas Wunner   2018-07-20  59  	((table##_t *)instance)->attr
c4db9c1e8c70bc Lukas Wunner   2018-07-20  60  
3552fdf29f01e5 Lukas Wunner   2016-11-12  61  #define efi_call_proto(protocol, f, instance, ...)			\
3552fdf29f01e5 Lukas Wunner   2016-11-12 @62  	((protocol##_t *)instance)->f(instance, ##__VA_ARGS__)
3552fdf29f01e5 Lukas Wunner   2016-11-12  63  

:::::: The code at line 53 was first introduced by commit
:::::: 81a0bc39ea1960bbf8ece6a895d7cfd2d9efa28a ARM: add UEFI stub support

:::::: TO: Roy Franz <roy.franz@...aro.org>
:::::: CC: ard <ard.biesheuvel@...aro.org>

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (48397 bytes)