linux-kernel - Re: [PATCH] KVM: vmx: remove unreachable statement in vmx_get_msr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DFEE8544-A246-45D0-A2DD-4AC4E7EC415E@oracle.com>
Date:   Thu, 5 Dec 2019 15:43:13 +0200
From:   Liran Alon <liran.alon@...cle.com>
To:     linmiaohe <linmiaohe@...wei.com>
Cc:     pbonzini@...hat.com, rkrcmar@...hat.com,
        sean.j.christopherson@...el.com, vkuznets@...hat.com,
        wanpengli@...cent.com, jmattson@...gle.com, joro@...tes.org,
        tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, hpa@...or.com,
        kvm@...r.kernel.org, linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH] KVM: vmx: remove unreachable statement in
 vmx_get_msr_feature()



> On 5 Dec 2019, at 4:24, linmiaohe <linmiaohe@...wei.com> wrote:
> 
> From: Miaohe Lin <linmiaohe@...wei.com>
> 
> We have no way to reach the final statement, remove it.
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> ---
> arch/x86/kvm/vmx/vmx.c | 2 --
> 1 file changed, 2 deletions(-)
> 
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index e7ea332ad1e8..e58a0daf0f86 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -1781,8 +1781,6 @@ static int vmx_get_msr_feature(struct kvm_msr_entry *msr)
> 	default:
> 		return 1;
> 	}
> -
> -	return 0;
> }

I personally just prefer to remove the “default” case and change this “return 0;” to “return 1;”.
But it’s a matter of taste of course.