linux-kernel - Re: [PATCH v2 2/2] thermal: armada: clear reset in armadaxp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <BN8PR10MB3379C4E94DECA65303064D9F8C5D0@BN8PR10MB3379.namprd10.prod.outlook.com>
Date:   Thu, 5 Dec 2019 14:19:28 +0000
From:   Zak Hays <zak.hays@...mark.com>
To:     Zak Hays <zak.hays@...mark.com>
CC:     "miquel.raynal@...tlin.com" <miquel.raynal@...tlin.com>,
        "rui.zhang@...el.com" <rui.zhang@...el.com>,
        "daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
        "amit.kucheria@...durent.com" <amit.kucheria@...durent.com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] thermal: armada: clear reset in armadaxp_init

The reset bit needs to be cleared in the init sequence otherwise it
holds the block in reset.

Signed-off-by: Zachary Hays <zhays@...mark.com>
---
v2: update commit title and add "Signed-off-by"
---
 drivers/thermal/armada_thermal.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c
index 88363812033c..8c4d1244ee7a 100644
--- a/drivers/thermal/armada_thermal.c
+++ b/drivers/thermal/armada_thermal.c
@@ -155,6 +155,9 @@ static void armadaxp_init(struct platform_device *pdev,

        regmap_write(priv->syscon, data->syscon_control1_off, reg);

+       reg &= ~PMU_TDC0_SW_RST_MASK;
+       regmap_write(priv->syscon, data->syscon_control1_off, reg);
+
        /* Enable the sensor */
        regmap_read(priv->syscon, data->syscon_status_off, &reg);
        reg &= ~PMU_TM_DISABLE_MASK;
--
2.7.4