linux-kernel - Re: [PATCH] /proc/stat: fix wrong cpustat gnice value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191205015819.GA14589@lenoir>
Date:   Thu, 5 Dec 2019 02:58:20 +0100
From:   Frederic Weisbecker <frederic@...nel.org>
To:     Flavio Leitner <fbl@...close.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] /proc/stat: fix wrong cpustat gnice value

On Wed, Dec 04, 2019 at 09:39:36PM -0300, Flavio Leitner wrote:
> The value being used for guest_nice should be CPUTIME_GUEST_NICE
> and not CPUTIME_USER.
> 
> Fixes: 26dae145a76c "procfs: Use all-in-one vtime aware kcpustat accessor"
> Signed-off-by: Flavio Leitner <fbl@...close.org>

Good catch, thanks!

> ---
>  fs/proc/stat.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/proc/stat.c b/fs/proc/stat.c
> index 37bdbec5b402..fd931d3e77be 100644
> --- a/fs/proc/stat.c
> +++ b/fs/proc/stat.c
> @@ -134,7 +134,7 @@ static int show_stat(struct seq_file *p, void *v)
>  		softirq		+= cpustat[CPUTIME_SOFTIRQ];
>  		steal		+= cpustat[CPUTIME_STEAL];
>  		guest		+= cpustat[CPUTIME_GUEST];
> -		guest_nice	+= cpustat[CPUTIME_USER];
> +		guest_nice	+= cpustat[CPUTIME_GUEST_NICE];
>  		sum		+= kstat_cpu_irqs_sum(i);
>  		sum		+= arch_irq_stat_cpu(i);
>  
> @@ -175,7 +175,7 @@ static int show_stat(struct seq_file *p, void *v)
>  		softirq		= cpustat[CPUTIME_SOFTIRQ];
>  		steal		= cpustat[CPUTIME_STEAL];
>  		guest		= cpustat[CPUTIME_GUEST];
> -		guest_nice	= cpustat[CPUTIME_USER];
> +		guest_nice	= cpustat[CPUTIME_GUEST_NICE];
>  		seq_printf(p, "cpu%d", i);
>  		seq_put_decimal_ull(p, " ", nsec_to_clock_t(user));
>  		seq_put_decimal_ull(p, " ", nsec_to_clock_t(nice));
> -- 
> 2.23.0
>