linux-kernel - Re: [PATCH] usb: musb: replace all unsigned data type to unsigned int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1575557578.6727.2.camel@mtkswgap22>
Date:   Thu, 5 Dec 2019 22:52:58 +0800
From:   Macpaul Lin <macpaul.lin@...iatek.com>
To:     Russell King - ARM Linux admin <linux@...linux.org.uk>
CC:     Mediatek WSD Upstream <wsd_upstream@...iatek.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Maxime Ripard <mripard@...nel.org>,
        "Chen-Yu Tsai" <wens@...e.org>,
        <linux-mediatek@...ts.infradead.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        <linux-omap@...r.kernel.org>, Bin Liu <b-liu@...com>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] usb: musb: replace all unsigned data type to unsigned
 int

On Thu, 2019-12-05 at 10:12 +0000, Russell King - ARM Linux admin wrote:
> On Thu, Dec 05, 2019 at 02:01:17PM +0800, Macpaul Lin wrote:
> > Simply replace all 'unsigned' data type in musb driver to
> > 'unsigned int' because it has been complained by gerrit
> > checkpatch service.
> 
> "unsigned" is perfectly legal standard C.  The policy for net related
> code is to abhor it, but there is nothing in the kernel style
> guidelines that prevents its use in the rest of the kernel.
> 
> AFAICS there is no need for this churn.

Thanks for your reply.
I'll bring this suggestion back to our internal checkpatch.pl owners to
align with kernel's rules.

Regards,
Macpaul Lin