linux-kernel - RE: [PATCH] drm: Add FEC registers for LT-tunable repeaters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR12MB3466044EF3A6E85160C3E6EF9E5C0@DM6PR12MB3466.namprd12.prod.outlook.com>
Date:   Thu, 5 Dec 2019 15:12:21 +0000
From:   "Liu, Zhan" <Zhan.Liu@....com>
To:     "Siqueira, Rodrigo" <Rodrigo.Siqueira@....com>,
        "=dri-devel@...ts.freedesktop.org" <=dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>
CC:     "Li, Sun peng (Leo)" <Sunpeng.Li@....com>,
        "Berthe, Abdoulaye" <Abdoulaye.Berthe@....com>,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        "Cornij, Nikola" <Nikola.Cornij@....com>,
        Manasi Navare <manasi.d.navare@...el.com>,
        "Wentland, Harry" <Harry.Wentland@....com>,
        Ville Syrjälä <ville.syrjala@...ux.intel.com>
Subject: RE: [PATCH] drm: Add FEC registers for LT-tunable repeaters



> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@...ts.freedesktop.org> On Behalf Of
> Rodrigo Siqueira
> Sent: 2019/December/05, Thursday 8:59 AM
> To: =dri-devel@...ts.freedesktop.org; linux-kernel@...r.kernel.org; amd-
> gfx@...ts.freedesktop.org
> Cc: Li, Sun peng (Leo) <Sunpeng.Li@....com>; Berthe, Abdoulaye
> <Abdoulaye.Berthe@....com>; Jani Nikula <jani.nikula@...ux.intel.com>;
> Cornij, Nikola <Nikola.Cornij@....com>; Manasi Navare
> <manasi.d.navare@...el.com>; Wentland, Harry
> <Harry.Wentland@....com>; Ville Syrjälä <ville.syrjala@...ux.intel.com>
> Subject: [PATCH] drm: Add FEC registers for LT-tunable repeaters
> 
> FEC is supported since DP 1.4, and it was expanded for LT-tunable in DP 1.4a.
> This commit adds the address registers for
> FEC_ERROR_COUNT_PHY_REPEATER1 and
> FEC_CAPABILITY_PHY_REPEATER1.
> 
> Cc: Abdoulaye Berthe <Abdoulaye.Berthe@....com>
> Cc: Harry Wentland <harry.wentland@....com>
> Cc: Leo Li <sunpeng.li@....com>
> Cc: Jani Nikula <jani.nikula@...ux.intel.com>
> Cc: Manasi Navare <manasi.d.navare@...el.com>
> Cc: Ville Syrjälä <ville.syrjala@...ux.intel.com>
> Signed-off-by: Abdoulaye Berthe <Abdoulaye.Berthe@....com>
> Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@....com>

Looks good to me.
Reviewed-by: Zhan Liu <zhan.liu@....com>

> ---
>  include/drm/drm_dp_helper.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 51ecb5112ef8..b2057009aabc 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -1042,6 +1042,8 @@
>  #define DP_SYMBOL_ERROR_COUNT_LANE2_PHY_REPEATER1
> 0xf0039 /* 1.3 */
>  #define DP_SYMBOL_ERROR_COUNT_LANE3_PHY_REPEATER1
> 0xf003b /* 1.3 */
>  #define DP_FEC_STATUS_PHY_REPEATER1			    0xf0290 /*
> 1.4 */
> +#define DP_FEC_ERROR_COUNT_PHY_REPEATER1                    0xf0291 /*
> 1.4 */
> +#define DP_FEC_CAPABILITY_PHY_REPEATER1                     0xf0294 /* 1.4a
> */
> 
>  /* Repeater modes */
>  #define DP_PHY_REPEATER_MODE_TRANSPARENT		    0x55    /*
> 1.3 */
> --
> 2.24.0
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.
> freedesktop.org%2Fmailman%2Flistinfo%2Famd-
> gfx&amp;data=02%7C01%7Czhan.liu%40amd.com%7Cfdbf92dcf79449d434e
> 208d7798b586d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6
> 37111511793172919&amp;sdata=SXDkgEpIQmTkmfFL0bXSBFwVxd9sSMWke
> V358fkkQZY%3D&amp;reserved=0