linux-kernel - Re: [PATCH 4.9 45/47] Smack: Dont ignore other bprm->unsafe flags if LSM_UNSAFE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64c5b8b423774029c3030ae778bf214d36499d2a.camel@decadent.org.uk>
Date:   Thu, 05 Dec 2019 15:50:07 +0000
From:   Ben Hutchings <ben@...adent.org.uk>
To:     Jann Horn <jannh@...gle.com>,
        Casey Schaufler <casey@...aufler-ca.com>
Cc:     stable@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4.9 45/47] Smack: Dont ignore other bprm->unsafe flags
 if LSM_UNSAFE_PTRACE is set

On Sun, 2019-10-06 at 19:21 +0200, Greg Kroah-Hartman wrote:
> From: Jann Horn <jannh@...gle.com>
> 
> commit 3675f052b43ba51b99b85b073c7070e083f3e6fb upstream.
[...]
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -949,7 +949,8 @@ static int smack_bprm_set_creds(struct l
>  
>  		if (rc != 0)
>  			return rc;
> -	} else if (bprm->unsafe)
> +	}
> +	if (bprm->unsafe & ~LSM_UNSAFE_PTRACE)

I think this needs to be ~(LSM_UNSAFE_PTRACE | LSM_UNSAFE_PTRACE_CAP)
for 4.9 and older branches.

Ben.

>  		return -EPERM;
>  
>  	bsp->smk_task = isp->smk_task;
> 
> 
-- 
Ben Hutchings
Every program is either trivial or else contains at least one bug


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)