linux-kernel - Re: [PATCH 4.19 084/321] scsi: qla2xxx: Fix NPIV handling for FC-NVMe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 Dec 2019 16:47:10 +0000
From:   Himanshu Madhani <hmadhani@...vell.com>
To:     Pavel Machek <pavel@...x.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 4.19 084/321] scsi: qla2xxx: Fix NPIV handling for FC-NVMe

Hello, 

On 12/4/19, 3:48 PM, "Pavel Machek" <linux-kernel-owner@...r.kernel.org on behalf of pavel@...x.de> wrote:

    Hi!
    
    > From: Himanshu Madhani <hmadhani@...vell.com>
    > 
    > [ Upstream commit 5e6803b409ba3c18434de6693062d98a470bcb1e ]
    > 
    > This patch fixes issues with NPIV port with FC-NVMe. Clean up code for
    > remoteport delete and also call nvme_delete when deleting VPs.
    
    > @@ -564,7 +554,7 @@ static void qla_nvme_remoteport_delete(struct nvme_fc_remote_port *rport)
    >  		schedule_work(&fcport->free_work);
    >  	}
    >  
    > -	fcport->nvme_flag &= ~(NVME_FLAG_REGISTERED | NVME_FLAG_DELETING);
    > +	fcport->nvme_flag &= ~NVME_FLAG_DELETING;
    >  	ql_log(ql_log_info, fcport->vha, 0x2110,
    >  	    "remoteport_delete of %p completed.\n", fcport);
    >  }
    
    Current -next-20191204 contains
    
     fcport->nvme_flag &= ~NVME_FLAG_REGISTERED;
     fcport->nvme_flag &= ~ NVME_FLAG_DELETING;
    
    ... and there's no explanation in changelog why removing
    NVME_FLAG_REGISTERED is good idea.

This patch was mostly cleanup and if you notice on line 541 we are already clearing up NVME_FLAG_REGISTERED flag.

e84067d743010 (Duane Grigsby               2017-06-21 13:48:43 -0700 541)       fcport->nvme_flag &= ~NVME_FLAG_REGISTERED;

so this patch is just removing duplicate clearing. At some point we will need to fix double line of clearing NVME_FLAG_REGISTERED and NVME_FLAG_DELETING
in one line. I'll send patch to fix that for net-next. 

Thanks,
Himanshu
    
    Are you sure this change is correct and suitable for -stable?
     								Pavel
    -- 
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html