linux-kernel - Re: [v3 PATCH] mm: move_pages: return valid node id in status if the page is already on the target node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 Dec 2019 19:45:49 +0000 (UTC)
From:   Christopher Lameter <cl@...ux.com>
To:     Yang Shi <yang.shi@...ux.alibaba.com>
cc:     fabecassis@...dia.com, jhubbard@...dia.com, mhocko@...e.com,
        vbabka@...e.cz, mgorman@...hsingularity.net,
        akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [v3 PATCH] mm: move_pages: return valid node id in status if
 the page is already on the target node

On Fri, 6 Dec 2019, Yang Shi wrote:

> Felix Abecassis reports move_pages() would return random status if the
> pages are already on the target node by the below test program:

Looks ok.

Acked-by: Christoph Lameter <cl@...ux.com>

Nitpicks:

> @@ -1553,7 +1555,7 @@ static int add_page_for_migration(struct mm_struct *mm, unsigned long addr,
>  	if (PageHuge(page)) {
>  		if (PageHead(page)) {
>  			isolate_huge_page(page, pagelist);
> -			err = 0;
> +			err = 1;

Add a meaningful constant instead of 1?

>  out:
>  	up_read(&mm->mmap_sem);
> +
>  	return err;

Dont do that.