linux-kernel - Re: [PATCH net v2] net: thunderx: start phy before starting autonegotiation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191205.121109.1735662506707982549.davem@davemloft.net>
Date:   Thu, 05 Dec 2019 12:11:09 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     ykaukab@...e.de
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, tharvey@...eworks.com,
        rric@...nel.org, sgoutham@...ium.com,
        sergei.shtylyov@...entembedded.com, andrew@...n.ch
Subject: Re: [PATCH net v2] net: thunderx: start phy before starting
 autonegotiation

From: Mian Yousaf Kaukab <ykaukab@...e.de>
Date: Thu,  5 Dec 2019 10:41:16 +0100

> Since commit 2b3e88ea6528 ("net: phy: improve phy state checking")
> phy_start_aneg() expects phy state to be >= PHY_UP. Call phy_start()
> before calling phy_start_aneg() during probe so that autonegotiation
> is initiated.
> 
> As phy_start() takes care of calling phy_start_aneg(), drop the explicit
> call to phy_start_aneg().
> 
> Network fails without this patch on Octeon TX.
> 
> Fixes: 2b3e88ea6528 ("net: phy: improve phy state checking")
> Signed-off-by: Mian Yousaf Kaukab <ykaukab@...e.de>

Applied and queued up for -stable, thanks.