linux-kernel - Re: "leds: gpio: Use generic support for composing LED names" breaks gpio debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 5 Dec 2019 22:29:24 +0100
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Russell King - ARM Linux admin <linux@...linux.org.uk>,
        Pavel Machek <pavel@....cz>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux LED Subsystem <linux-leds@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: "leds: gpio: Use generic support for composing LED names" breaks
 gpio debugfs

On 12/5/19 12:45 AM, Linus Walleij wrote:
> On Wed, Dec 4, 2019 at 9:52 PM Jacek Anaszewski
> <jacek.anaszewski@...il.com> wrote:
> 
>> It seem that the only proper solution would be introducing a new
>> pre_register_cdev(const char *name) op to the LED core, that would allow
>> drivers to come up with their implementation thereof. In this particular
>> case leds-gpio driver would need to put there gpiod initialization.
> 
> I don't know the particulars but if it helps you can at any point
> call:
> int gpiod_set_consumer_name(struct gpio_desc *desc, const char *name);
> 
> For any successfully obtained descriptor, to set the consumer name,
> i.e. the text appearing in debugfs and the GPIO character device.

Thanks for the pointer. I've just used that to fix the issue.

-- 
Best regards,
Jacek Anaszewski