linux-kernel - Re: [PATCH v2] RDMA/cma: add missed unregister_pernet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <005ae1f8-3241-4a7e-aa1e-eb26275d15a9@mellanox.com>
Date:   Fri, 6 Dec 2019 04:32:43 +0000
From:   Parav Pandit <parav@...lanox.com>
To:     Chuhong Yuan <hslester96@...il.com>
CC:     Doug Ledford <dledford@...hat.com>, Jason Gunthorpe <jgg@...pe.ca>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] RDMA/cma: add missed unregister_pernet_subsys in init
 failure

On 12/5/2019 7:24 PM, Chuhong Yuan wrote:
> The driver forgets to call unregister_pernet_subsys() in the error path
> of cma_init().
> Add the missed call to fix it.
> 
> Fixes: 4be74b42a6d0 ("IB/cma: Separate port allocation to network namespaces")
> Signed-off-by: Chuhong Yuan <hslester96@...il.com>
> ---
> Changes in v2:
>   - Add fixes tag.
> 
>  drivers/infiniband/core/cma.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
> index 25f2b70fd8ef..43a6f07e0afe 100644
> --- a/drivers/infiniband/core/cma.c
> +++ b/drivers/infiniband/core/cma.c
> @@ -4763,6 +4763,7 @@ static int __init cma_init(void)
>  err:
>  	unregister_netdevice_notifier(&cma_nb);
>  	ib_sa_unregister_client(&sa_client);
> +	unregister_pernet_subsys(&cma_pernet_operations);
>  err_wq:
>  	destroy_workqueue(cma_wq);
>  	return ret;
> 
Reviewed-by: Parav Pandit <parav@...lanox.com>