linux-kernel - Re: [PATCH v3 1/2] drm: call drm_gem_object

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 Dec 2019 11:07:24 +0100
From:   Gerd Hoffmann <kraxel@...hat.com>
To:     dri-devel@...ts.freedesktop.org, robh@...nel.org,
        intel-gfx@...ts.freedesktop.org,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        David Airlie <airlied@...ux.ie>,
        Christian Koenig <christian.koenig@....com>,
        Huang Rui <ray.huang@....com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/2] drm: call drm_gem_object_funcs.mmap with fake
 offset

On Thu, Dec 05, 2019 at 11:15:23PM +0100, Daniel Vetter wrote:
> On Thu, Nov 28, 2019 at 12:39:30PM +0100, Gerd Hoffmann wrote:
> > On Wed, Nov 27, 2019 at 10:25:22AM +0100, Gerd Hoffmann wrote:
> > > The fake offset is going to stay, so change the calling convention for
> > > drm_gem_object_funcs.mmap to include the fake offset.  Update all users
> > > accordingly.
> > > 
> > > Note that this reverts 83b8a6f242ea ("drm/gem: Fix mmap fake offset
> > > handling for drm_gem_object_funcs.mmap") and on top then adds the fake
> > > offset to  drm_gem_prime_mmap to make sure all paths leading to
> > > obj->funcs->mmap are consistent.
> > > 
> > > v3: move fake-offset tweak in drm_gem_prime_mmap() so we have this code
> > >     only once in the function (Rob Herring).
> > 
> > Now this series fails in Intel CI.  Can't see why though.  The
> > difference between v2 and v3 is just the place where vma->vm_pgoff gets
> > updated, and no code between the v2 and v3 location touches vma ...
> 
> Looks like unrelated flukes, this happens occasionally. If you're paranoid
> hit the retest button on patchwork to double-check.
> -Daniel

Guess you kicked CI?  Just got CI mails, now reporting success, without
doing anything.  So I'll go push v3 to misc-next.

cheers,
  Gerd