lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <6d9e3468-aa27-95d9-5d01-660298a6e9ac@redhat.com>
Date:   Fri, 6 Dec 2019 14:16:09 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     linmiaohe <linmiaohe@...wei.com>, rkrcmar@...hat.com,
        sean.j.christopherson@...el.com, vkuznets@...hat.com,
        wanpengli@...cent.com, jmattson@...gle.com, joro@...tes.org,
        tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, hpa@...or.com
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH] KVM: x86: Fix some comment typos

On 06/12/19 09:20, linmiaohe wrote:
> From: Miaohe Lin <linmiaohe@...wei.com>
> 
> Fix some typos in comment.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> ---
>  arch/x86/kvm/mmu/mmu.c | 2 +-
>  arch/x86/kvm/vmx/vmx.c | 2 +-
>  arch/x86/kvm/x86.c     | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
> index a81c605abbba..0684b90070de 100644
> --- a/arch/x86/kvm/mmu/mmu.c
> +++ b/arch/x86/kvm/mmu/mmu.c
> @@ -1525,7 +1525,7 @@ struct rmap_iterator {
>  /*
>   * Iteration must be started by this function.  This should also be used after
>   * removing/dropping sptes from the rmap link because in such cases the
> - * information in the itererator may not be valid.
> + * information in the iterator may not be valid.
>   *
>   * Returns sptep if found, NULL otherwise.
>   */
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index e58a0daf0f86..e82772d9ab48 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -1371,7 +1371,7 @@ void vmx_vcpu_load_vmcs(struct kvm_vcpu *vcpu, int cpu)
>  		/*
>  		 * VM exits change the host TR limit to 0x67 after a VM
>  		 * exit.  This is okay, since 0x67 covers everything except
> -		 * the IO bitmap and have have code to handle the IO bitmap
> +		 * the IO bitmap and we have code to handle the IO bitmap
>  		 * being lost after a VM exit.
>  		 */
>  		BUILD_BUG_ON(IO_BITMAP_OFFSET - 1 != 0x67);
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 3ed167e039e5..392d473252f8 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -9790,7 +9790,7 @@ static void kvm_mmu_slot_apply_flags(struct kvm *kvm,
>  	 *
>  	 * The reason is, in case of PML, we need to set D-bit for any slots
>  	 * with dirty logging disabled in order to eliminate unnecessary GPA
> -	 * logging in PML buffer (and potential PML buffer full VMEXT). This
> +	 * logging in PML buffer (and potential PML buffer full VMEXIT). This
>  	 * guarantees leaving PML enabled during guest's lifetime won't have
>  	 * any additional overhead from PML when guest is running with dirty
>  	 * logging disabled for memory slots.
> 

Queued, thanks.

Paolo

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ