linux-kernel - Re: [PATCH 1/2] dt-bindings: tcan4x5x: Make wake-gpio an optional gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 Dec 2019 14:49:52 +0100
From:   Sean Nyekjaer <sean@...nix.com>
To:     Dan Murphy <dmurphy@...com>, mkl@...gutronix.de
Cc:     linux-can@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, Rob Herring <robh@...nel.org>
Subject: Re: [PATCH 1/2] dt-bindings: tcan4x5x: Make wake-gpio an optional
 gpio



On 05/12/2019 08.36, Sean Nyekjaer wrote:
> 
> 
> On 04/12/2019 18.51, Dan Murphy wrote:
>> The wake-up of the device can be configured as an optional
>> feature of the device.  Move the wake-up gpio from a requried
>> property to an optional property.
>>
>> Signed-off-by: Dan Murphy <dmurphy@...com>
>> CC: Rob Herring <robh@...nel.org>
> Reviewed-by: Sean Nyekjaer <sean@...nix.com>
Tested-by: Sean Nyekjaer <sean@...nix.com>
>> ---
>>   Documentation/devicetree/bindings/net/can/tcan4x5x.txt | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt 
>> b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
>> index 27e1b4cebfbd..7cf5ef7acba4 100644
>> --- a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
>> +++ b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
>> @@ -10,7 +10,6 @@ Required properties:
>>       - #size-cells: 0
>>       - spi-max-frequency: Maximum frequency of the SPI bus the chip can
>>                    operate at should be less than or equal to 18 MHz.
>> -    - device-wake-gpios: Wake up GPIO to wake up the TCAN device.
>>       - interrupt-parent: the phandle to the interrupt controller 
>> which provides
>>                       the interrupt.
>>       - interrupts: interrupt specification for data-ready.
>> @@ -23,6 +22,7 @@ Optional properties:
>>                  reset.
>>       - device-state-gpios: Input GPIO that indicates if the device is in
>>                     a sleep state or if the device is active.
>> +    - device-wake-gpios: Wake up GPIO to wake up the TCAN device.
>>   Example:
>>   tcan4x5x: tcan4x5x@0 {
>>