linux-kernel - Re: [PATCH] media: go7007: fix a miss of snd_card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f6fcd441-e92d-0fff-e488-9507999b1682@web.de>
Date:   Fri, 6 Dec 2019 15:10:52 +0100
From:   Markus Elfring <Markus.Elfring@....de>
To:     Chuhong Yuan <hslester96@...il.com>, linux-media@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH] media: go7007: fix a miss of snd_card_free

> go7007_snd_init() misses a snd_card_free() in an error path.
> Add the missed call to fix it.

How do you think about to take another look also at the previous update suggestion
“[PATCH 5/6] [media] go7007: Use common error handling code in go7007_snd_init()”?
https://lore.kernel.org/linux-media/05efac78-3a14-803c-5b4a-68670728628b@users.sourceforge.net/
https://lore.kernel.org/patchwork/patch/831887/
https://lkml.org/lkml/2017/9/19/115

Regards,
Markus