linux-kernel - Re: [git pull] vfs.git d_inode/d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 Dec 2019 02:28:51 +0000
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        Ritesh Harjani <riteshh@...ux.ibm.com>
Subject: Re: [git pull] vfs.git d_inode/d_flags barriers

On Thu, Dec 05, 2019 at 06:15:54PM -0800, Linus Torvalds wrote:
> On Thu, Dec 5, 2019 at 5:38 PM Al Viro <viro@...iv.linux.org.uk> wrote:
> >
> >   git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git fixes
> 
> I'm not pulling this.
> 
> Commit 6c2d4798a8d1 ("new helper: lookup_positive_unlocked()") results
> in a new - and valid - compiler warning:
> 
>   fs/quota/dquot.c: In function ‘dquot_quota_on_mount’:
>   fs/quota/dquot.c:2499:1: warning: label ‘out’ defined but not used
> [-Wunused-label]
>    2499 | out:
>         | ^~~
> 
> and I don't want to see new warnings in my tree.
> 
> I wish linux-next would complain about warnings (assuming this had
> been there), because they aren't ok.

Fixed...  Could you pull #fixes1 instead?  diff is literally removal of one
line; updated shortlog/diffstat follows:

The following changes since commit 3e5aeec0e267d4422a4e740ce723549a3098a4d1:

  cramfs: fix usage on non-MTD device (2019-11-23 21:44:49 -0500)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git fixes1

for you to fetch changes up to 7fcd59b64a7b69718cc851865a1578138b481541:

  fs/namei.c: fix missing barriers when checking positivity (2019-12-05 21:04:35 -0500)

----------------------------------------------------------------
Al Viro (4):
      fs/namei.c: pull positivity check into follow_managed()
      new helper: lookup_positive_unlocked()
      fix dget_parent() fastpath race
      fs/namei.c: fix missing barriers when checking positivity

 fs/cifs/cifsfs.c       |  7 +------
 fs/dcache.c            |  6 ++++--
 fs/debugfs/inode.c     |  6 +-----
 fs/kernfs/mount.c      |  2 +-
 fs/namei.c             | 56 ++++++++++++++++++++++++++++----------------------
 fs/nfsd/nfs3xdr.c      |  4 +---
 fs/nfsd/nfs4xdr.c      | 11 +---------
 fs/overlayfs/namei.c   | 24 ++++++++--------------
 fs/quota/dquot.c       |  8 +-------
 include/linux/dcache.h |  5 +++++
 include/linux/namei.h  |  1 +
 11 files changed, 56 insertions(+), 74 deletions(-)