linux-kernel - Re: media: go7007: fix a miss of snd_card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aa5555c7-48fb-11f9-d79b-5d72bee55ff9@web.de>
Date:   Fri, 6 Dec 2019 18:00:24 +0100
From:   Markus Elfring <Markus.Elfring@....de>
To:     Chuhong Yuan <hslester96@...il.com>, linux-media@...r.kernel.org
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: media: go7007: fix a miss of snd_card_free

> I think using goto is really much better than freeing after every error.

Thanks for your positive feedback.

> I will send a new version if others also agree with this pattern.

* The error handling pattern would be supported by the Linux coding style.
  The agreement on corresponding changes can occasionally become more challenging.

* I would interpret Dan Carpenter's review comment (from 2017-09-19) in the way
  that he should be mentioned by the tag “Reported-by” in a subsequent patch.
  https://lkml.org/lkml/2017/9/19/115

Regards,
Markus