linux-kernel - Re: [PATCH] net: stmmac: reset Tx desc base address before restarting Tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191206.115050.2225203369041453711.davem@davemloft.net>
Date:   Fri, 06 Dec 2019 11:50:50 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     neidhard.kim@....com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-stm32@...md-mailman.stormreply.com,
        mcoquelin.stm32@...il.com, joabreu@...opsys.com,
        alexandre.torgue@...com, peppe.cavallaro@...com
Subject: Re: [PATCH] net: stmmac: reset Tx desc base address before
 restarting Tx

From: Jongsung Kim <neidhard.kim@....com>
Date: Fri,  6 Dec 2019 20:40:00 +0900

> Refer to the databook of DesignWare Cores Ethernet MAC Universal:
> 
> 6.2.1.5 Register 4 (Transmit Descriptor List Address Register
> 
> If this register is not changed when the ST bit is set to 0, then
> the DMA takes the descriptor address where it was stopped earlier.
> 
> The stmmac_tx_err() does zero indices to Tx descriptors, but does
> not reset HW current Tx descriptor address. To fix inconsistency,
> the base address of the Tx descriptors should be rewritten before
> restarting Tx.
> 
> Signed-off-by: Jongsung Kim <neidhard.kim@....com>

Applied.