linux-kernel - Re: [GIT PULL] tpmdd updates for Linux v5.4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191206211834.GD9971@linux.intel.com>
Date:   Fri, 6 Dec 2019 23:18:34 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Dan Williams <dan.j.williams@...el.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-integrity@...r.kernel.org, James Morris <jmorris@...ei.org>,
        Stefan Berger <stefanb@...ux.vnet.ibm.com>,
        stable <stable@...r.kernel.org>
Subject: Re: [GIT PULL] tpmdd updates for Linux v5.4

On Fri, Nov 29, 2019 at 05:12:53PM -0700, Jerry Snitselaar wrote:
> On Sat Nov 30 19, Jarkko Sakkinen wrote:
> > On Wed, Nov 27, 2019 at 06:20:55PM -0700, Jerry Snitselaar wrote:
> > > There also was that other issue reported on the list about
> > > tpm_tis_core_init failing when calling tpm_get_timeouts due to the
> > > power gating changes.
> > 
> > Please add a (lore.ko) link for reference to this thread.
> > 
> > /Jarkko
> > 
> 
> https://lore.kernel.org/linux-integrity/a60dadce-3650-44ce-8785-2f737ab9b993@www.fastmail.com/

tpm_chip_stop() probably causes the issue. That is why tpm2_probe()
works and failure happens after that.

tpm_chip_stop() should be called once at the end of the function.

/Jarkko