linux-kernel - Re: [PATCH v5 02/13] exfat: add super block operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKYAXd9yW2j+MqExyxJmN2-bTKMarwebrBKefBZgfj+HF+bpbg@mail.gmail.com>
Date:   Sat, 7 Dec 2019 06:55:25 +0900
From:   Namjae Jeon <linkinjeon@...il.com>
To:     Valdis Klētnieks <valdis.kletnieks@...edu>
Cc:     Namjae Jeon <namjae.jeon@...sung.com>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        gregkh@...uxfoundation.org, hch@....de, Markus.Elfring@....de,
        sj1557.seo@...sung.com, dwagner@...e.de, nborisov@...e.com
Subject: Re: [PATCH v5 02/13] exfat: add super block operations

>> +{
>> +	struct exfat_sb_info *sbi = sb->s_fs_info;
>> +	struct exfat_mount_options *opts = &sbi->options;
>> +	struct inode *root_inode;
>> +	int err;
>> +
>> +	if (opts->allow_utime == -1)
>> +		opts->allow_utime = ~opts->fs_dmask & 0022;
>
> This throws a warning when building with W=1:
>
>   CC [M]  fs/exfat/super.o
> fs/exfat/super.c: In function 'exfat_fill_super':
> fs/exfat/super.c:552:24: warning: comparison is always false due to limited
> range of data type [-Wtype-limits]
>   552 |  if (opts->allow_utime == -1)
>       |                        ^~
Okay, I will fix it on next version.
Thanks for review!