linux-kernel - Re: [PATCH] debugfs: Return -EPERM when locked down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191206234318.GA16467@bombadil.infradead.org>
Date:   Fri, 6 Dec 2019 15:43:18 -0800
From:   Matthew Wilcox <willy@...radead.org>
To:     Eric Snowberg <eric.snowberg@...cle.com>
Cc:     gregkh@...uxfoundation.org, rafael@...nel.org, dhowells@...hat.com,
        matthewgarrett@...gle.com, jmorris@...ei.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] debugfs: Return -EPERM when locked down

On Fri, Dec 06, 2019 at 05:59:09PM -0500, Eric Snowberg wrote:
> -static bool debugfs_is_locked_down(struct inode *inode,
> +static int debugfs_is_locked_down(struct inode *inode,

I might rename this function to debugfs_locked_down() to make it sound
less like it returns a boolean.

Other than that,

Reviewed-by: Matthew Wilcox (Oracle) <willy@...radead.org>