linux-kernel - Re: [PATCH] KVM: vmx: remove unreachable statement in vmx_get_msr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c7423896f6f49f2a2b439afe809db08@huawei.com>
Date:   Fri, 6 Dec 2019 03:41:33 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     Wanpeng Li <kernellwp@...il.com>
CC:     Liran Alon <liran.alon@...cle.com>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "rkrcmar@...hat.com" <rkrcmar@...hat.com>,
        "sean.j.christopherson@...el.com" <sean.j.christopherson@...el.com>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        "wanpengli@...cent.com" <wanpengli@...cent.com>,
        "jmattson@...gle.com" <jmattson@...gle.com>,
        "joro@...tes.org" <joro@...tes.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>, "hpa@...or.com" <hpa@...or.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>
Subject: Re: [PATCH] KVM: vmx: remove unreachable statement in
 vmx_get_msr_feature()

Wanpeng Li <kernellwp@...il.com> wrote:
>>
>> >
>> >I personally just prefer to remove the “default” case and change this “return 0;” to “return 1;”.
>> >But it’s a matter of taste of course.
>> >
>> Yes. As what " Turnip greens, all have love " said. ^_^
>
>Actually it is a great appreciated to introduce something more useful instead of tons of cleanups, I saw guys did one cleanup and can incur several bugs before.
>
I'd like to introduce something more useful, but side corner cleanups may be hard to
found out something to introduce. And such cleanups can also be validated by code inspection
to avoid something bad. Many thanks.