linux-kernel - Re: [PATCH] time: posix-stubs: provide compat itimer supoprt for alpha

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191207225424.GA9476@roeck-us.net>
Date:   Sat, 7 Dec 2019 14:54:24 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-alpha@...r.kernel.org, Richard Henderson <rth@...ddle.net>,
        Ivan Kokshaysky <ink@...assic.park.msu.ru>,
        Matt Turner <mattst88@...il.com>,
        kbuild test robot <lkp@...el.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] time: posix-stubs: provide compat itimer supoprt for
 alpha

On Sat, Dec 07, 2019 at 08:10:26PM +0100, Arnd Bergmann wrote:
> Using compat_sys_getitimer and compat_sys_setitimer on alpha
> causes a link failure in the Alpha tinyconfig and other configurations
> that turn off CONFIG_POSIX_TIMERS.
> 
> Use the same #ifdef check for the stub version as well.
> 
> Reported-by: Guenter Roeck <linux@...ck-us.net>
> Reported-by: kbuild test robot <lkp@...el.com>
> Fixes: 4c22ea2b9120 ("y2038: use compat_{get,set}_itimer on alpha")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Tested-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  kernel/time/posix-stubs.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/kernel/time/posix-stubs.c b/kernel/time/posix-stubs.c
> index 67df65f887ac..20c65a7d4e3a 100644
> --- a/kernel/time/posix-stubs.c
> +++ b/kernel/time/posix-stubs.c
> @@ -151,6 +151,9 @@ SYSCALL_DEFINE4(clock_nanosleep, const clockid_t, which_clock, int, flags,
>  
>  #ifdef CONFIG_COMPAT
>  COMPAT_SYS_NI(timer_create);
> +#endif
> +
> +#if defined(CONFIG_COMPAT) || defined(CONFIG_ALPHA)
>  COMPAT_SYS_NI(getitimer);
>  COMPAT_SYS_NI(setitimer);
>  #endif
> -- 
> 2.20.0
>