linux-kernel - Re: [Patch v2 5/6] x86/mm: Use address directly in split_mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 7 Dec 2019 11:36:10 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Wei Yang <richardw.yang@...ux.intel.com>
Cc:     kbuild-all@...ts.01.org, x86@...nel.org,
        linux-kernel@...r.kernel.org, richard.weiyang@...il.com,
        dave.hansen@...ux.intel.com, luto@...nel.org, peterz@...radead.or,
        tglx@...utronix.de, Wei Yang <richardw.yang@...ux.intel.com>
Subject: Re: [Patch v2 5/6] x86/mm: Use address directly in split_mem_range()

Hi Wei,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/x86/mm]
[also build test ERROR on tip/auto-latest linus/master v5.4 next-20191206]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Wei-Yang/x86-mm-Remove-second-argument-of-split_mem_range/20191207-061345
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 7f264dab5b60343358e788d4c939c166c22ea4a2
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Debian 7.5.0-1) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

Note: the linux-review/Wei-Yang/x86-mm-Remove-second-argument-of-split_mem_range/20191207-061345 HEAD 7f535395f79354bfa29cca182dd203525bcb4237 builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   arch/x86/mm/init.c: In function 'save_mr':
>> arch/x86/mm/init.c:265:6: error: 'start_pfn' undeclared (first use in this function); did you mean 'start'?
     if (start_pfn < end_pfn) {
         ^~~~~~~~~
         start
   arch/x86/mm/init.c:265:6: note: each undeclared identifier is reported only once for each function it appears in
>> arch/x86/mm/init.c:265:18: error: 'end_pfn' undeclared (first use in this function); did you mean 'pgd_pfn'?
     if (start_pfn < end_pfn) {
                     ^~~~~~~
                     pgd_pfn

vim +265 arch/x86/mm/init.c

f765090a2617b8 Pekka Enberg 2009-03-05  260  
dc9dd5cc854cde Jan Beulich  2009-03-12  261  static int __meminit save_mr(struct map_range *mr, int nr_range,
51c6d529efdc86 Wei Yang     2019-12-05  262  			     unsigned long start, unsigned long end,
f765090a2617b8 Pekka Enberg 2009-03-05  263  			     unsigned long page_size_mask)
f765090a2617b8 Pekka Enberg 2009-03-05  264  {
f765090a2617b8 Pekka Enberg 2009-03-05 @265  	if (start_pfn < end_pfn) {
f765090a2617b8 Pekka Enberg 2009-03-05  266  		if (nr_range >= NR_RANGE_MR)
f765090a2617b8 Pekka Enberg 2009-03-05  267  			panic("run out of range for init_memory_mapping\n");
51c6d529efdc86 Wei Yang     2019-12-05  268  		mr[nr_range].start = start_pfn;
51c6d529efdc86 Wei Yang     2019-12-05  269  		mr[nr_range].end   = end_pfn;
f765090a2617b8 Pekka Enberg 2009-03-05  270  		mr[nr_range].page_size_mask = page_size_mask;
f765090a2617b8 Pekka Enberg 2009-03-05  271  		nr_range++;
f765090a2617b8 Pekka Enberg 2009-03-05  272  	}
f765090a2617b8 Pekka Enberg 2009-03-05  273  
f765090a2617b8 Pekka Enberg 2009-03-05  274  	return nr_range;
f765090a2617b8 Pekka Enberg 2009-03-05  275  }
f765090a2617b8 Pekka Enberg 2009-03-05  276  

:::::: The code at line 265 was first introduced by commit
:::::: f765090a2617b8d9cb73b71e0aa850c29460d8be x86: move init_memory_mapping() to common mm/init.c

:::::: TO: Pekka Enberg <penberg@...helsinki.fi>
:::::: CC: Ingo Molnar <mingo@...e.hu>

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (7223 bytes)