linux-kernel - Re: [PATCH] KVM: get rid of var page in kvm_set_pfn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <488cb59fccb74338aa7b8b7dcfc0c4fc@huawei.com>
Date:   Sat, 7 Dec 2019 07:21:02 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     Sean Christopherson <sean.j.christopherson@...el.com>
CC:     "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "rkrcmar@...hat.com" <rkrcmar@...hat.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] KVM: get rid of var page in kvm_set_pfn_dirty()

Sean Christopherson wrote:
>On Thu, Dec 05, 2019 at 11:05:05AM +0800, linmiaohe wrote:
>> From: Miaohe Lin <linmiaohe@...wei.com>
>> 
>> We can get rid of unnecessary var page in
>> kvm_set_pfn_dirty() , thus make code style similar with 
>> kvm_set_pfn_accessed().
>
>For future reference, there's no need to wrap so aggressively, preferred kernel style is to wrap at 75 columns (though for some reason I am in the habit of wrapping changelogs at 73 columns), e.g.:
>
>We can get rid of unnecessary var page in kvm_set_pfn_dirty(), thus make code style similar with kvm_set_pfn_accessed().
>
Many thanks for your remind. I would try to wrap changelogs at about 75 columns.
Thanks again.