linux-kernel - Re: [PATCH] iio: adc: Move AD7091R5 entry in a alphabetical order in Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 7 Dec 2019 10:18:14 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Beniamin Bia <beniamin.bia@...log.com>
Cc:     <lars@...afoo.de>, <pmeerw@...erw.net>,
        <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <knaack.h@....de>, <fabrice.gasnier@...com>,
        <biabeniamin@...look.com>
Subject: Re: [PATCH] iio: adc: Move AD7091R5 entry in a alphabetical order
 in Makefile

On Tue, 3 Dec 2019 12:17:13 +0200
Beniamin Bia <beniamin.bia@...log.com> wrote:

> Ad7091R5 was added in a non alphabetical order after AD7124 in Makefile and
> KConfig. This patch fixes that and place Ad7091R5 before AD7124.
> 
> Signed-off-by: Beniamin Bia <beniamin.bia@...log.com>
Applied to the togreg branch of iio.git and pushed out as testing to
make not difference (hopefully :)

Jonathan

> ---
>  drivers/iio/adc/Kconfig  | 14 +++++++-------
>  drivers/iio/adc/Makefile |  2 +-
>  2 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 976567d4dbef..27bb4e56eaea 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -21,6 +21,13 @@ config AD_SIGMA_DELTA
>  	select IIO_BUFFER
>  	select IIO_TRIGGERED_BUFFER
>  
> +config AD7091R5
> +	tristate "Analog Devices AD7091R5 ADC Driver"
> +	depends on I2C
> +	select REGMAP_I2C
> +	help
> +	  Say yes here to build support for Analog Devices AD7091R-5 ADC.
> +
>  config AD7124
>  	tristate "Analog Devices AD7124 and similar sigma-delta ADCs driver"
>  	depends on SPI_MASTER
> @@ -32,13 +39,6 @@ config AD7124
>  	  To compile this driver as a module, choose M here: the module will be
>  	  called ad7124.
>  
> -config AD7091R5
> -	tristate "Analog Devices AD7091R5 ADC Driver"
> -	depends on I2C
> -	select REGMAP_I2C
> -	help
> -	  Say yes here to build support for Analog Devices AD7091R-5 ADC.
> -
>  config AD7266
>  	tristate "Analog Devices AD7265/AD7266 ADC driver"
>  	depends on SPI_MASTER
> diff --git a/drivers/iio/adc/Makefile b/drivers/iio/adc/Makefile
> index 84936ec24411..bf8354cdbc34 100644
> --- a/drivers/iio/adc/Makefile
> +++ b/drivers/iio/adc/Makefile
> @@ -6,8 +6,8 @@
>  # When adding new entries keep the list in alphabetical order
>  obj-$(CONFIG_AB8500_GPADC) += ab8500-gpadc.o
>  obj-$(CONFIG_AD_SIGMA_DELTA) += ad_sigma_delta.o
> -obj-$(CONFIG_AD7124) += ad7124.o
>  obj-$(CONFIG_AD7091R5) += ad7091r5.o ad7091r-base.o
> +obj-$(CONFIG_AD7124) += ad7124.o
>  obj-$(CONFIG_AD7266) += ad7266.o
>  obj-$(CONFIG_AD7291) += ad7291.o
>  obj-$(CONFIG_AD7292) += ad7292.o