linux-kernel - [PATCH 3.16 10/72] video: of: display_timing: Add of_node_put() in of_get_display

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <lsq.1575813165.830287385@decadent.org.uk>
Date:   Sun, 08 Dec 2019 13:52:54 +0000
From:   Ben Hutchings <ben@...adent.org.uk>
To:     linux-kernel@...r.kernel.org, stable@...r.kernel.org
CC:     akpm@...ux-foundation.org, Denis Kirjanov <kda@...ux-powerpc.org>,
        "David Airlie" <airlied@...ux.ie>,
        "Laurent Pinchart" <laurent.pinchart@...asonboard.com>,
        "Philipp Zabel" <p.zabel@...gutronix.de>,
        "Thierry Reding" <thierry.reding@...il.com>,
        "Sam Ravnborg" <sam@...nborg.org>,
        "Tomi Valkeinen" <tomi.valkeinen@...com>,
        "Bartlomiej Zolnierkiewicz" <b.zolnierkie@...sung.com>,
        "Russell King" <linux@...linux.org.uk>,
        "Daniel Vetter" <daniel@...ll.ch>,
        "Douglas Anderson" <dianders@...omium.org>
Subject: [PATCH 3.16 10/72] video: of: display_timing: Add of_node_put()
 in of_get_display_timing()

3.16.79-rc1 review patch.  If anyone has any objections, please let me know.

------------------

From: Douglas Anderson <dianders@...omium.org>

commit 4faba50edbcc1df467f8f308893edc3fdd95536e upstream.

=46romcode inspection it can be seen that of_get_display_timing() is
lacking an of_node_put().  Add it.

Fixes: ffa3fd21de8a ("videomode: implement public of_get_display_timing()")
Signed-off-by: Douglas Anderson <dianders@...omium.org>
Reviewed-by: Sam Ravnborg <sam@...nborg.org>
Cc: Thierry Reding <thierry.reding@...il.com>
Cc: David Airlie <airlied@...ux.ie>
Cc: Philipp Zabel <p.zabel@...gutronix.de>
Cc: Tomi Valkeinen <tomi.valkeinen@...com>
Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: Russell King <linux@...linux.org.uk>
Cc: Daniel Vetter <daniel@...ll.ch>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190722182439.44844-2-dianders@chromium.org
Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
---
 drivers/video/of_display_timing.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

--- a/drivers/video/of_display_timing.c
+++ b/drivers/video/of_display_timing.c
@@ -114,6 +114,7 @@ int of_get_display_timing(struct device_
 		struct display_timing *dt)
 {
 	struct device_node *timing_np;
+	int ret;
 
 	if (!np)
 		return -EINVAL;
@@ -125,7 +126,11 @@ int of_get_display_timing(struct device_
 		return -ENOENT;
 	}
 
-	return of_parse_display_timing(timing_np, dt);
+	ret = of_parse_display_timing(timing_np, dt);
+
+	of_node_put(timing_np);
+
+	return ret;
 }
 EXPORT_SYMBOL_GPL(of_get_display_timing);